Build: Give linting sub-commands a directory to run against #17545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17542
What I did
I was very confused when running
yarn lint:js
did not result in any files being linted. I've now realized that the target (.
) is specified in the parent command,yarn lint
. It seems to me like commands should do the thing they say they're doing, without needing extra arguments in order to function. So, I've moved the.
into the linting subcommands here. I'm happy to close this out if there are reasons to keep it apart, but it was definitely confusing to me.How to test
You can run
yarn lint:js --debug
to verify that it is indeed running against files now.